unittest: Fix function QCHECK (issue #2517)

stweil · stweil · commit 252d80cb6dfd · 2019-06-23T19:05:42.000+02:00
The function must print an error message if the condition fails.

Signed-off-by: Stefan Weil &lt;sw@weilnetz.de&gt;
diff --git a/unittest/log.h b/unittest/log.h
@@ -45,11 +45,11 @@ static inline std::ostream& LOG(enum LogLevel level)
 // https://github.com/google/ion/blob/master/ion/base/logging.h
 static inline std::ostream& QCHECK(bool condition)
 {
-  static std::ostream null_stream(nullptr);
   if (condition) {
-    return std::cout;
+    static std::ostream null_stream(nullptr);
+    return null_stream;
   }
-  return null_stream;
+  return std::cout;
 }
 
 #endif  // TESSERACT_UNITTEST_LOG_H_

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,11 @@ static inline std::ostream& LOG(enum LogLevel level)`
`45`	`45`	`// https://github.com/google/ion/blob/master/ion/base/logging.h`
`46`	`46`	`static inline std::ostream& QCHECK(bool condition)`
`47`	`47`	`{`
`48`		`- static std::ostream null_stream(nullptr);`
`49`	`48`	`if (condition) {`
`50`		`- return std::cout;`
	`49`	`+ static std::ostream null_stream(nullptr);`
	`50`	`+ return null_stream;`
`51`	`51`	`}`
`52`		`- return null_stream;`
	`52`	`+ return std::cout;`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`#endif // TESSERACT_UNITTEST_LOG_H_`