Skip to content

Commit 2bb0d9a

Browse files
committed
opencl: Add missing checks for OpenCL failures
Fix also text for an existing check. Signed-off-by: Stefan Weil <sw@weilnetz.de>
1 parent 3e11fc1 commit 2bb0d9a

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

opencl/openclwrapper.cpp

+14-2
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,7 @@ PERF_COUNT_START("pixReadFromTiffKernel")
766766

767767
l_uint32 *pResult = (l_uint32 *)malloc(w*h * sizeof(l_uint32));
768768
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "composeRGBPixel", &clStatus );
769-
CHECK_OPENCL( clStatus, "clCreateKernel");
769+
CHECK_OPENCL( clStatus, "clCreateKernel composeRGBPixel");
770770

771771
//Allocate input and output OCL buffers
772772
valuesCl = allocateZeroCopyBuffer(rEnv, tiffdata, w*h, CL_MEM_READ_ONLY | CL_MEM_USE_HOST_PTR, &clStatus);
@@ -1390,6 +1390,7 @@ pixDilateCL_55(l_int32 wpl, l_int32 h)
13901390
localThreads[1] = GROUPSIZE_HMORY;
13911391

13921392
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "morphoDilateHor_5x5", &status );
1393+
CHECK_OPENCL(status, "clCreateKernel morphoDilateHor_5x5");
13931394

13941395
status = clSetKernelArg(rEnv.mpkKernel,
13951396
0,
@@ -1432,6 +1433,7 @@ pixDilateCL_55(l_int32 wpl, l_int32 h)
14321433
localThreads[1] = GROUPSIZE_Y;
14331434

14341435
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "morphoDilateVer_5x5", &status );
1436+
CHECK_OPENCL(status, "clCreateKernel morphoDilateVer_5x5");
14351437

14361438
status = clSetKernelArg(rEnv.mpkKernel,
14371439
0,
@@ -1484,6 +1486,7 @@ pixErodeCL_55(l_int32 wpl, l_int32 h)
14841486
localThreads[1] = GROUPSIZE_HMORY;
14851487

14861488
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "morphoErodeHor_5x5", &status );
1489+
CHECK_OPENCL(status, "clCreateKernel morphoErodeHor_5x5");
14871490

14881491
status = clSetKernelArg(rEnv.mpkKernel,
14891492
0,
@@ -1526,6 +1529,7 @@ pixErodeCL_55(l_int32 wpl, l_int32 h)
15261529
localThreads[1] = GROUPSIZE_Y;
15271530

15281531
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "morphoErodeVer_5x5", &status );
1532+
CHECK_OPENCL(status, "clCreateKernel morphoErodeVer_5x5");
15291533

15301534
status = clSetKernelArg(rEnv.mpkKernel,
15311535
0,
@@ -1603,6 +1607,7 @@ pixDilateCL(l_int32 hsize, l_int32 vsize, l_int32 wpl, l_int32 h)
16031607
// Generic case.
16041608
rEnv.mpkKernel =
16051609
clCreateKernel(rEnv.mpkProgram, "morphoDilateHor", &status);
1610+
CHECK_OPENCL(status, "clCreateKernel morphoDilateHor");
16061611

16071612
status = clSetKernelArg(rEnv.mpkKernel, 0, sizeof(cl_mem), &pixsCLBuffer);
16081613
status = clSetKernelArg(rEnv.mpkKernel, 1, sizeof(cl_mem), &pixdCLBuffer);
@@ -1626,6 +1631,7 @@ pixDilateCL(l_int32 hsize, l_int32 vsize, l_int32 wpl, l_int32 h)
16261631
// Specific Horizontal pass kernel for half width < 32
16271632
rEnv.mpkKernel =
16281633
clCreateKernel(rEnv.mpkProgram, "morphoDilateHor_32word", &status);
1634+
CHECK_OPENCL(status, "clCreateKernel morphoDilateHor_32word");
16291635
isEven = (xp != xn);
16301636

16311637
status = clSetKernelArg(rEnv.mpkKernel, 0, sizeof(cl_mem), &pixsCLBuffer);
@@ -1644,12 +1650,13 @@ pixDilateCL(l_int32 hsize, l_int32 vsize, l_int32 wpl, l_int32 h)
16441650
pixtemp = pixsCLBuffer;
16451651
pixsCLBuffer = pixdCLBuffer;
16461652
pixdCLBuffer = pixtemp;
1647-
}
1653+
}
16481654
}
16491655

16501656
if (yp > 0 || yn > 0)
16511657
{
16521658
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "morphoDilateVer", &status );
1659+
CHECK_OPENCL(status, "clCreateKernel morphoDilateVer");
16531660

16541661
status = clSetKernelArg(rEnv.mpkKernel,
16551662
0,
@@ -1781,6 +1788,7 @@ cl_int pixErodeCL(l_int32 hsize, l_int32 vsize, l_uint32 wpl, l_uint32 h) {
17811788
// Vertical Pass
17821789
if (yp > 0 || yn > 0) {
17831790
rEnv.mpkKernel = clCreateKernel(rEnv.mpkProgram, "morphoErodeVer", &status);
1791+
CHECK_OPENCL(status, "clCreateKernel morphoErodeVer");
17841792

17851793
status = clSetKernelArg(rEnv.mpkKernel, 0, sizeof(cl_mem), &pixsCLBuffer);
17861794
status = clSetKernelArg(rEnv.mpkKernel, 1, sizeof(cl_mem), &pixdCLBuffer);
@@ -1926,6 +1934,7 @@ pixORCL_work(l_uint32 wpl, l_uint32 h, cl_mem buffer1, cl_mem buffer2, cl_mem ou
19261934
globalThreads[1] = gsize;
19271935

19281936
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "pixOR", &status );
1937+
CHECK_OPENCL(status, "clCreateKernel pixOR");
19291938

19301939
status = clSetKernelArg(rEnv.mpkKernel,
19311940
0,
@@ -1975,6 +1984,7 @@ pixANDCL_work(l_uint32 wpl, l_uint32 h, cl_mem buffer1, cl_mem buffer2, cl_mem o
19751984
globalThreads[1] = gsize;
19761985

19771986
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "pixAND", &status );
1987+
CHECK_OPENCL(status, "clCreateKernel pixAND");
19781988

19791989
// Enqueue a kernel run call.
19801990
status = clSetKernelArg(rEnv.mpkKernel,
@@ -2027,10 +2037,12 @@ pixSubtractCL_work(l_uint32 wpl, l_uint32 h, cl_mem buffer1, cl_mem buffer2, cl_
20272037
if (outBuffer != nullptr)
20282038
{
20292039
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "pixSubtract", &status );
2040+
CHECK_OPENCL(status, "clCreateKernel pixSubtract");
20302041
}
20312042
else
20322043
{
20332044
rEnv.mpkKernel = clCreateKernel( rEnv.mpkProgram, "pixSubtract_inplace", &status );
2045+
CHECK_OPENCL(status, "clCreateKernel pixSubtract_inplace");
20342046
}
20352047

20362048
// Enqueue a kernel run call.

0 commit comments

Comments
 (0)