Adding announcementDuration to Firebase-Ace package #82
Locked
lakbychance
started this conversation in
General
Replies: 1 comment
-
My bad, should have made this change as part of #76. Added #83 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hey @Progyan1997 , now that the remote tooltip implementation is done, the
FireAceEditor
constructor can acceptannouncementDuration
as inFireMonacoEditor
. So the change also has to go in@otjs/firebase-ace
package. Plus README also has to be updated accordingly for both@otjs/ace
and@otjs/firebase-ace
. Can you raise an issue for the same ? TBH, I am not a fan of bugging the maintainers every time when raising an issue 🤔 .Beta Was this translation helpful? Give feedback.
All reactions