-
Notifications
You must be signed in to change notification settings - Fork 12
Refactor curl dependency #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd be in favor of this. What would the solution look like on our end using submodules? |
It should follow the same pattern we use for other submodules. cpp-crypto/src is a good example of this. In the specific case of curl, it would go in ./src/lib/curl. Ideally, we would build curl via cmake and add_subdirectory. The framework is there but curl is complex to build. |
@ciband Big refactor is coming soon to Cpp-Client and Cpp-Crypto, @faustbrian We can probably close this out now since cURL will be dropped from Cpp-Client altogether. |
This issue has been closed. If you wish to re-open it please provide additional information. |
Is your feature request related to a problem? Please describe.
The hunter package manager is not ideal and is hard to work with. It also locks you into a particular version of the software, usually old.
Describe the solution you'd like
I would like to see the curl dependency converted to a git submodule for maximum flexibility.
Describe alternatives you've considered
Another option would be to use something other than curl as a submodule to accomplish the same thing.
Additional context
N/A
The text was updated successfully, but these errors were encountered: