Skip to content

ci: update arduino triggers #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2019
Merged

ci: update arduino triggers #132

merged 3 commits into from
Sep 29, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Summary

This PR adjusts the Arduino CI paths for GH Actions.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Sep 27, 2019
@sleepdefic1t
Copy link
Contributor Author

@faustbrian
gtg 👍

Hopefully this can help kick start the #126 workflow again too.

@sleepdefic1t sleepdefic1t requested a review from ciband September 27, 2019 01:30
@sleepdefic1t sleepdefic1t mentioned this pull request Sep 27, 2019
18 tasks
@faustbrian
Copy link
Contributor

It would be better to use the GITHUB_WORKSPACE environment variable as documented at https://help.github.com/en/articles/virtual-environments-for-github-actions#environment-variables to avoid having to change that path if they do change it internally.

@sleepdefic1t
Copy link
Contributor Author

@faustbrian
Right on, the path only changed bc we switched to Actions which has different dir names, and the bash scripts copy to an Arduino library dir that has to be in home; so that workspace variable isn’t all that helpful in this case.

I can add it if you’d like, but we’d still need to use the system paths for the majority of the workflow.

@faustbrian
Copy link
Contributor

faustbrian commented Sep 27, 2019

Shouldn't something like mv ${GITHUB_WORKSPACE}/* ~/Arduino/libraries/cpp-client/ work in that case if only the arduino folder has to stay where it is?

@faustbrian
Copy link
Contributor

@sleepdefic1t https://github.com/ArkEcosystem/cpp-client/runs/238286766 looks good?

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #132 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #132   +/-   ##
========================================
  Coverage    79.47%   79.47%           
========================================
  Files           26       26           
  Lines          497      497           
========================================
  Hits           395      395           
  Misses         102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23cc61...a216f52. Read the comment docs.

@sleepdefic1t
Copy link
Contributor Author

@faustbrian
Looks good to me 👍

@faustbrian faustbrian merged commit 5ba9d18 into develop Sep 29, 2019
@ghost ghost deleted the ci/arduino-trigger branch September 29, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants