fix: rename helpers #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misc: merge from upstream
Cpp-Crypto uses the header 'helpers/helpers.h'. Cpp-Client also uses this 'helpers/helpers.h' naming. These headers are not identical and contain only “helper” functions specific to its library. When both Cpp-Client & Cpp-Crypto are included in the same project, it results in a name collision causing one of the headers to be dropped. This PR renames 'helpers/helpers.h' to 'helpers/crypto_helpers.h’, and resolves the name collision.
12 tasks
|
ArkEcosystem/cpp-client #51 matches this revised naming. |
|
Failing Linux build also showed up in #50 and is unrelated to these changes. |
|
#52 should resolve failing linux build. |
faustbrian
approved these changes
Jan 28, 2019
ciband
pushed a commit
to ciband/cpp-crypto
that referenced
this pull request
Feb 18, 2019
Cpp-Crypto uses the header 'helpers/helpers.h'. Cpp-Client also uses this 'helpers/helpers.h' naming. These headers are not identical and contain only “helper” functions specific to its library. When both Cpp-Client & Cpp-Crypto are included in the same project, it results in a name collision causing one of the headers to be dropped. This PR renames 'helpers/helpers.h' to 'helpers/crypto_helpers.h’, and resolves the name collision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Cpp-Crypto uses the header 'helpers/helpers.h'.
Cpp-Client also uses this 'helpers/helpers.h' naming.
These headers are not identical and contain only “helper” functions specific to its library.
When both Cpp-Client & Cpp-Crypto are included in the same project, it results in one of the headers being dropped.
This PR renames 'helpers/helpers.h' to 'helpers/crypto_helpers.h’, and resolves the name collision.
Types of changes
Checklist
Further comments
There will also be a PR in ArkEcosystem/Cpp-Client to match this revised naming.