Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dewallua is not included in the release or installation instructions #3

Closed
Nattie-G opened this issue Nov 4, 2021 · 2 comments
Closed

Comments

@Nattie-G
Copy link

Nattie-G commented Nov 4, 2021

Installing Strike as per the readme instructions leads to a crash and error due to the dewallua library not being included in the release. The github repo links to the correct files in your dewallua repo and copying them in will resolve this. however by default, the files are not included when downloading or cloning the repo.

Error: Strike/Strike.lua:1: module 'Strike.lib.DeWallua.vector-light' not found:
	no field package.preload['Strike.lib.DeWallua.vector-light']
	no 'Strike/lib/DeWallua/vector-light' in LOVE game directories.
	no file 'Strike/lib/DeWallua/vector-light' in LOVE paths.
	no file './Strike/lib/DeWallua/vector-light.lua'
	no file '/usr/share/luajit-2.0.5/Strike/lib/DeWallua/vector-light.lua'
	no file '/usr/local/share/lua/5.1/Strike/lib/DeWallua/vector-light.lua'
	no file '/usr/local/share/lua/5.1/Strike/lib/DeWallua/vector-light/init.lua'
	no file '/usr/share/lua/5.1/Strike/lib/DeWallua/vector-light.lua'
	no file '/usr/share/lua/5.1/Strike/lib/DeWallua/vector-light/init.lua'
	no file './Strike/lib/DeWallua/vector-light.so'
	no file '/usr/local/lib/lua/5.1/Strike/lib/DeWallua/vector-light.so'
	no file '/usr/lib/lua/5.1/Strike/lib/DeWallua/vector-light.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
	no file './Strike.so'
	no file '/usr/local/lib/lua/5.1/Strike.so'
	no file '/usr/lib/lua/5.1/Strike.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
	[string "boot.lua"]:777: in function <[string "boot.lua"]:773>
	[C]: in function '_Require_relative'
	Strike/Strike.lua:1: in main chunk
	[C]: in function 'require'
	Strike/init.lua:26: in main chunk
	[C]: in function 'require'
	main.lua:1: in main chunk
	[C]: in function 'require'
	[string "boot.lua"]:570: in function <[string "boot.lua"]:380>
	[C]: in function 'xpcall'
	[string "boot.lua"]:787: in function <[string "boot.lua"]:780>
	[C]: in function 'xpcall'```
@Aweptimum
Copy link
Owner

You're right! The installation instructions are lacking.
I think adding this to the Installation section should be enough to prevent others from experiencing this:

If using git's command line to clone Strike, run either of the following commands to clone it:
git clone --recurse-submodules https://github.com/Aweptimum/Strike.git (git >= 2.13)
git clone --recursive https://github.com/Aweptimum/Strike.git (git < 2.13)
If using github desktop, it automatically resolves submodules, so no command-line needed

@Nattie-G
Copy link
Author

Nattie-G commented Nov 4, 2021

I tested cloning the repo using the --recursive-submodules flag in git v 2.33.0 and can confirm it fetches the dewallua lib as desired, resolving the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants