Skip to content

Commit 9f66f6b

Browse files
[Storage] Revert removing aiohttp dependency for storage.blob.aio (#25084)
1 parent 6d89670 commit 9f66f6b

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

sdk/storage/azure-storage-blob/CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
### Bugs Fixed
88
- Stable release of features from 12.13.0b1.
99
- Added support for deleting versions in `delete_blobs` by supplying `version_id`.
10-
- Removed forced `aiohttp` import from storage async download. (#24965)
1110

1211
## 12.13.0b1 (2022-06-15)
1312

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_download_async.py

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
from typing import AsyncIterator
1313

1414
import asyncio
15-
16-
from azure.core.exceptions import HttpResponseError, ServiceResponseError, IncompleteReadError
15+
from aiohttp import ClientPayloadError
16+
from azure.core.exceptions import HttpResponseError, ServiceResponseError
1717

1818
from .._shared.request_handlers import validate_and_format_range_headers
1919
from .._shared.response_handlers import process_storage_error, parse_length_from_content_range
@@ -114,15 +114,14 @@ async def _download_chunk(self, chunk_start, chunk_end):
114114
)
115115
retry_active = False
116116

117-
except IncompleteReadError as error:
117+
except HttpResponseError as error:
118+
process_storage_error(error)
119+
except ClientPayloadError as error:
118120
retry_total -= 1
119121
if retry_total <= 0:
120122
raise ServiceResponseError(error, error=error)
121123
await asyncio.sleep(1)
122124

123-
except HttpResponseError as error:
124-
process_storage_error(error)
125-
126125
chunk_data = await process_content(response, offset[0], offset[1], self.encryption_options)
127126

128127

@@ -357,12 +356,6 @@ async def _initial_request(self):
357356
self.size = self._file_size
358357
retry_active = False
359358

360-
except IncompleteReadError as error:
361-
retry_total -= 1
362-
if retry_total <= 0:
363-
raise ServiceResponseError(error, error=error)
364-
await asyncio.sleep(1)
365-
366359
except HttpResponseError as error:
367360
if self._start_range is None and error.response.status_code == 416:
368361
# Get range will fail on an empty file. If the user did not
@@ -384,6 +377,12 @@ async def _initial_request(self):
384377
else:
385378
process_storage_error(error)
386379

380+
except ClientPayloadError as error:
381+
retry_total -= 1
382+
if retry_total <= 0:
383+
raise ServiceResponseError(error, error=error)
384+
await asyncio.sleep(1)
385+
387386
# get page ranges to optimize downloading sparse page blob
388387
if response.properties.blob_type == 'PageBlob':
389388
try:

0 commit comments

Comments
 (0)