Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Term checks #154

Closed
aalda opened this issue Aug 5, 2019 · 0 comments · Fixed by #172
Closed

Remove Term checks #154

aalda opened this issue Aug 5, 2019 · 0 comments · Fixed by #172
Assignees
Labels
clean up propose a clean up or a redesign of ugly things
Milestone

Comments

@aalda
Copy link
Contributor

aalda commented Aug 5, 2019

In the method shouldApply of the fsm.go file, we are performing some checks on the log entry to verify in the command to apply has already been processed. We are checking the Term, the Index and the Balloon's version but in fact, we don't need to check the Term because the Index is a global sequence number and does not start over with any new Term.

@aalda aalda added the clean up propose a clean up or a redesign of ugly things label Aug 5, 2019
@aalda aalda added this to the 1.0.0-rc2 milestone Aug 5, 2019
@aalda aalda self-assigned this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up propose a clean up or a redesign of ugly things
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant