Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require user reporting of GKR gate degrees #1411

Open
Tabaie opened this issue Feb 4, 2025 · 4 comments
Open

Don't require user reporting of GKR gate degrees #1411

Tabaie opened this issue Feb 4, 2025 · 4 comments
Assignees
@Tabaie
Labels
consolidate strengthen an existing feature good first issue Good for newcomers P3: Low Issue priority: low

Comments

@Tabaie
Copy link
Contributor

Tabaie commented Feb 4, 2025

Cumbersome and error-prone (confusions over total degree or maximum degree over a single variable, forgetting to change after editing the gate etc.)

Similar to TestGateDegree in gnark-crypto, automatically determine the gate's degree at compile time and store it in the constraint system metadata.
@Tabaie Tabaie assigned Tabaie and unassigned Tabaie Feb 4, 2025
@Tabaie Tabaie added good first issue Good for newcomers consolidate strengthen an existing feature P3: Low Issue priority: low labels Feb 4, 2025
@MuhtasimTanmoy
Copy link

On it.

@Tabaie Tabaie mentioned this issue Feb 12, 2025
Merged
@ivokub
Copy link
Collaborator

ivokub commented Feb 13, 2025

See Consensys/gnark-crypto#628 (comment) for a proposal of the implementation.

@MuhtasimTanmoy
Copy link

Thanks.

@Tabaie Tabaie self-assigned this Feb 25, 2025
@Tabaie
Copy link
Contributor Author

Tabaie commented Feb 25, 2025

Consensys/gnark-crypto#652 addresses this on the gnark-crypto side. gnark PR in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tabaie Tabaie

Labels
consolidate strengthen an existing feature good first issue Good for newcomers P3: Low Issue priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ivokub @Tabaie @MuhtasimTanmoy