Jigsaw Output CSMState String #5675

chkim-usgs · 2024-11-20T18:56:41Z

Description

This PR is dependent on this ALE bugfix PR to get tests passing.

Related Issue

Addresses #5609

How Has This Been Validated?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change (update to the documentation; no code change)
Breaking change (fix or feature that would cause existing functionality to change)
Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

I have read and agree to abide by the Code of Conduct
I have read the CONTRIBUTING document.
My change requires a change to the documentation and I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added myself to the .zenodo.json document.
I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions · 2024-11-20T18:57:27Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

acpaquette · 2024-11-20T19:13:44Z

isis/src/control/apps/jigsaw/jigsaw.cpp

+    setenv("ALESPICEROOT", "/Volumes/t7-shield/isis_data", true);
+    json props;
+    props["web"] = true;
+    json isd = ale::load(filename0.toStdString(), props.dump(), "isis", true, false, false);


This line should be:

json isd = ale::load(filename0.toStdString(), props.dump(), "ale", true, true, false);

The "ale" format is used in both ISIS and USGSCSM, then we want to set the first true so that we don't generate new spice data but read existing data from the ISIS cube

github-actions · 2024-11-22T03:14:51Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-03-27T20:01:16Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-04-01T16:20:35Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-04-01T18:18:51Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-04-03T19:45:16Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-04-04T13:09:30Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-04-04T14:47:44Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-04-04T17:39:38Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs · 2025-04-07T17:21:58Z

environment.yml

@@ -3,7 +3,7 @@ channels:
  - usgs-astrogeology

 dependencies:
-  - ale =0.10.0,<1


Make sure to add this update to the recipe/meta.yaml otherwise the dev release builds will fail.

github-actions · 2025-04-07T17:32:47Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

acpaquette

Overall looks great! One small addition and this should be good to merge

acpaquette · 2025-04-16T18:44:16Z

isis/src/control/apps/jigsaw/jigsaw.cpp

+
+        // Generate ISD from cube
+        json props;
+        json isd = ale::load(filename.toStdString(), props.dump(), "ale", false, true, false);


We should throw a try/catch around this load call. It will likely fail at some point as not all instruments have an IsisLabelIsisSpice driver

github-actions · 2025-04-16T19:38:23Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5675".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

wip

70fc83c

acpaquette reviewed Nov 20, 2024

View reviewed changes

More updates and refactor

e47cbf0

Merge branch 'DOI-USGS:dev' into jigsaw_csmstate_output

73ae14f

Add jigsaw csm state test

2e992cd

chkim-usgs mentioned this pull request Apr 1, 2025

Cast SpkTableOriginalSize as integer DOI-USGS/ale#642

Merged

1 task

Update changelog

0ab4cc7

chkim-usgs marked this pull request as ready for review April 1, 2025 18:18

Update ale to 0.11.0

9398dbe

Merge branch 'dev' into jigsaw_csmstate_output

0f17333

Empty commit

2081657

Add csmplugins to test preferences

4aeb42c

amystamile-usgs reviewed Apr 7, 2025

View reviewed changes

Update ale in meta.yaml

afaf5b0

acpaquette reviewed Apr 16, 2025

View reviewed changes

Added try/catch around ale load()

9e3321b

acpaquette approved these changes Apr 16, 2025

View reviewed changes

acpaquette merged commit 0da5775 into DOI-USGS:dev Apr 16, 2025
2 checks passed

Jigsaw Output CSMState String #5675

Jigsaw Output CSMState String #5675

Uh oh!

Conversation

chkim-usgs commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

How Has This Been Validated?

Types of changes

Checklist:

Licensing

Uh oh!

github-actions bot commented Nov 20, 2024

Uh oh!

acpaquette Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 22, 2024

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

amystamile-usgs Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

acpaquette left a comment

Choose a reason for hiding this comment

Uh oh!

acpaquette Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

chkim-usgs commented Nov 20, 2024 •

edited

Loading