Skip to content

Performance: unnecessary ServerCheckGuard api call #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
YanaDePauw opened this issue Mar 12, 2025 · 0 comments · May be fixed by #4100
Open

Performance: unnecessary ServerCheckGuard api call #4074

YanaDePauw opened this issue Mar 12, 2025 · 0 comments · May be fixed by #4100
Assignees
@YanaDePauw
Labels
bug performance / caching Related to performance, caching or embedded objects

Comments

@YanaDePauw
Copy link
Contributor

Describe the bug

After getting rid of the of /server/api request for #3961, one more /server/api check was found in the ServerCheckGuard that will be performed with every load to check if the server is not down.

This can still affect performance when a slower REST API is used.

The server check can be made more "positive" since any other call will also fail when the server is down. This can be leveraged to avoid having to make the additional api call on every page load.

Related work

#3961
@YanaDePauw YanaDePauw added bug needs triage New issue needs triage and/or scheduling labels Mar 12, 2025
@YanaDePauw YanaDePauw self-assigned this Mar 12, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Mar 12, 2025
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Mar 12, 2025
@tdonohue tdonohue added performance / caching Related to performance, caching or embedded objects and removed needs triage New issue needs triage and/or scheduling labels Mar 12, 2025
@AAwouters AAwouters mentioned this issue Mar 14, 2025
Draft
12 tasks
@YanaDePauw YanaDePauw linked a pull request Mar 19, 2025 that will close this issue
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YanaDePauw YanaDePauw

Labels
bug performance / caching Related to performance, caching or embedded objects
Projects
DSpace 8.x and 7.6.x Maintenance
Status: 🏗 In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Server check guard change 7 x atmire/dspace-angular
2 participants
@tdonohue @YanaDePauw