Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large refactoring in progress if anyone interested #129

Open
srad opened this issue Feb 22, 2025 · 1 comment
Open

Large refactoring in progress if anyone interested #129

srad opened this issue Feb 22, 2025 · 1 comment

Comments

@srad
Copy link

srad commented Feb 22, 2025

I started to make a pretty big refactoring of the code base, if anyone is interested:

https://github.com/srad/QualityScaler/tree/resolution-fit

Changes I made:

  • refactored the QualityScaler.py file into individual modules and classes
  • No global variables (only file with default values)
  • and already fixed minor issue and added new features, like
    • showing only the available GPU by name in the GPU dropdown box
    • automatically setting the maximal available GPU memory when the GPU is selected (and on launch)
  • logging instead of printf
  • Using correct python and patterns naming convention.
  • Adding more type hints
  • The entire codebase is already 500 lines less code than the original QualityScaler.py file (cloc . --exclude-dir=.venv,venv,AI-onnx,Assets --exclude-ext=md,txt,bat,xml) and it will shrink more

It not entire fixed yet, since I'm still working on it. But the application can be launched and everything looks right.

@MarcG2
Copy link

MarcG2 commented Mar 12, 2025

Since you're familiar with the codebase, can you comment any about the color shift issue I observed? Any ideas for a work around?

#131

I hope you don't mind me asking. I have no idea when the dev will look into it and I really want to get some upscales done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants