Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android hybrid - The app log out the Gmail account after finish the add bank flow #58704

Open
1 of 8 tasks
mitarachim opened this issue Mar 19, 2025 · 12 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@mitarachim
Copy link

mitarachim commented Mar 19, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.15-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5766403&group_by=cases:section_id&group_id=306205&group_order=asc
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Pixel 7 Pro /Android 15
App Component: Workspace Settings

Action Performed:

  1. Login with a brand new Gmail account
  2. Select the Onboarding "Manage my team's expense/ 1-10 employees" and finish the onboarding flow
  3. Navigate to the Workflow in the WS settings
  4. Tap on the Connect bank account button
  5. Enter the MC to verify the account
  6. Follow and finish the plaid flow

Expected Result:

The user continues to the personal information step.

Actual Result:

After finishing the Plaid flow the app auto-logs out of the account

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6775420_1742383969770.Bank_log_out.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021903132107310368328
  • Upwork Job ID: 1903132107310368328
  • Last Price Increase: 2025-03-21
Issue OwnerCurrent Issue Owner: @parasharrajat
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 19, 2025
Copy link

melvin-bot bot commented Mar 19, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 19, 2025

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 19, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 19, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@iwiznia
Copy link
Contributor

iwiznia commented Mar 19, 2025

Given this is only android and hybrid app, I don't think it can be a backend issue, so removing that label

@iwiznia iwiznia removed the DeployBlocker Indicates it should block deploying the API label Mar 19, 2025
@iwiznia
Copy link
Contributor

iwiznia commented Mar 19, 2025

I think blocking app is correct, since this test passed yesterday. Trying to figure out what could've caused this. Diff is here 9.1.14-5...9.1.15-1

@mountiny
Copy link
Contributor

btw discussing this extensively here

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 20, 2025
@mountiny
Copy link
Contributor

In the thread, Marcin found out the root cause and its also reproducible in production, so demoting, they are working on a fix

@war-in
Copy link
Contributor

war-in commented Mar 20, 2025

Yes, hi! To sum up - the real issue is that we don't send any data to OD once we validate the account.

So the real steps are

  • create a new account
  • be redirected to ND after clicking Join
  • go to Profile -> Contact methods -> click on your email and validate it
  • click Switch to Expensify Classic
  • be signed out (you shouldn't)

What we should do next - send required data to OD (probably authToken, but hasn't verified that yet) every time we validate the account

I'm going to work on this and hopefully have a PR tomorrow 🫡

@war-in
Copy link
Contributor

war-in commented Mar 20, 2025

I can also confirm it's reproducible on both android and ios hybrid apps

@iwiznia iwiznia added the External Added to denote the issue can be worked on by a contributor label Mar 21, 2025
@melvin-bot melvin-bot bot changed the title Android hybrid - The app log out the Gmail account after finish the add bank flow [$250] Android hybrid - The app log out the Gmail account after finish the add bank flow Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021903132107310368328

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants