Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users with "Approve change requests" permission for tagged features cannot approve change requests #5225

Open
1 of 4 tasks
rolodato opened this issue Mar 12, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Member

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

A user with permissions to only create and approve change requests for features with a certain tag cannot actually approve such change requests.

To see this in action, look at the user rodrigo.lopezdato+1@flagsmith.com in organisation ID 15467. For example, this change request is for a feature tagged with marketing, but the user cannot approve it:

Image

Steps To Reproduce

  1. Create a role and assign it permissions to only create and approve change requests for features with a specific tag, in some environment
  2. Assign this role to a group, and add your user to it
  3. As a different user, create a change request for a feature in this environment with this specific tag
  4. With the original user, visit the change request created in the previous step. The user cannot approve the change request

Image

Expected behavior

Users with "Approve change requests" (granted for tags) permission should be able to approve these change requests.

Screenshots

No response

@rolodato rolodato added the bug Something isn't working label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant