Skip to content

feat: improve configuration #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2024
Merged

feat: improve configuration #169

merged 4 commits into from
Apr 12, 2024

Conversation

RobertIndie
Copy link
Contributor

@RobertIndie RobertIndie commented Apr 10, 2024

This PR is to refine the configuration system for Function Stream. Now, the configuration system for Function Stream is finally established. It can support various file formats, including YAML and JSON, and even read configurations from environment variables. This will be significantly beneficial when we operate Function Stream on Kubernetes in the future.

Preview

The configuration will look like:

listen_addr: ":7300"
tube_factory:
  pulsar:
    type: "pulsar"
    config:
      pulsar_url: "pulsar://localhost:6650"
  memory:
    Type: "memory"
  default:
    ref: "pulsar"
runtime_factory:
  wasm:
    type: "wasm"
  default:
    ref: "wasm"

Signed-off-by: Zike Yang <zike@apache.org>
Signed-off-by: Zike Yang <zike@apache.org>
Signed-off-by: Zike Yang <zike@apache.org>
@RobertIndie RobertIndie self-assigned this Apr 10, 2024
Signed-off-by: Zike Yang <zike@apache.org>
@RobertIndie RobertIndie marked this pull request as ready for review April 11, 2024 15:59
Copy link
Contributor

@wyyolo wyyolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, this greatly formalizes the configuration system!

@RobertIndie RobertIndie merged commit 18e6ea3 into main Apr 12, 2024
4 checks passed
@RobertIndie RobertIndie deleted the improve-config branch April 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants