From ed783a1a9daa2894651f86caa9aa662d0f0b5183 Mon Sep 17 00:00:00 2001 From: Zeno Kapitein Date: Tue, 6 May 2025 11:43:21 +0200 Subject: [PATCH 1/4] Prevent section group popovers from opening on click --- .changeset/thirty-donkeys-help.md | 5 +++++ .../gitbook/src/components/SiteSections/SiteSectionTabs.tsx | 6 ++++++ 2 files changed, 11 insertions(+) create mode 100644 .changeset/thirty-donkeys-help.md diff --git a/.changeset/thirty-donkeys-help.md b/.changeset/thirty-donkeys-help.md new file mode 100644 index 0000000000..529b8a9024 --- /dev/null +++ b/.changeset/thirty-donkeys-help.md @@ -0,0 +1,5 @@ +--- +"gitbook": patch +--- + +Prevent section group popovers from opening on click diff --git a/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx b/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx index 2833f9f31a..f3475e75fc 100644 --- a/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx +++ b/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx @@ -83,6 +83,12 @@ export function SiteSectionTabs(props: { sections: ClientSiteSections }) { ) } asChild + onClick={(e) => { + if (value) { + e.preventDefault(); + e.stopPropagation(); + } + }} > Date: Tue, 6 May 2025 12:09:24 +0200 Subject: [PATCH 2/4] Change to prevent hover --- .../components/SiteSections/SiteSectionTabs.tsx | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx b/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx index f3475e75fc..de4eb1682d 100644 --- a/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx +++ b/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx @@ -83,12 +83,9 @@ export function SiteSectionTabs(props: { sections: ClientSiteSections }) { ) } asChild - onClick={(e) => { - if (value) { - e.preventDefault(); - e.stopPropagation(); - } - }} + onPointerOver={(e) => e.preventDefault()} + onPointerMove={(e) => e.preventDefault()} + onPointerLeave={(e) => e.preventDefault()} > - + e.preventDefault()} + onPointerLeave={(e) => e.preventDefault()} + > Date: Tue, 6 May 2025 14:56:22 +0200 Subject: [PATCH 3/4] Revert "Change to prevent hover" This reverts commit db5e51d3b77d8d48646bf615c0ca23149f23c171. --- .../components/SiteSections/SiteSectionTabs.tsx | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx b/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx index de4eb1682d..f3475e75fc 100644 --- a/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx +++ b/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx @@ -83,9 +83,12 @@ export function SiteSectionTabs(props: { sections: ClientSiteSections }) { ) } asChild - onPointerOver={(e) => e.preventDefault()} - onPointerMove={(e) => e.preventDefault()} - onPointerLeave={(e) => e.preventDefault()} + onClick={(e) => { + if (value) { + e.preventDefault(); + e.stopPropagation(); + } + }} > - e.preventDefault()} - onPointerLeave={(e) => e.preventDefault()} - > + Date: Tue, 6 May 2025 14:57:50 +0200 Subject: [PATCH 4/4] Add default cursor to section groups --- .../gitbook/src/components/SiteSections/SiteSectionTabs.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx b/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx index f3475e75fc..8496845507 100644 --- a/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx +++ b/packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx @@ -186,7 +186,7 @@ const SectionGroupTab = React.forwardRef(function SectionGroupTab( ref={ref} {...rest} className={tcls( - 'group relative my-2 flex select-none items-center justify-between rounded straight-corners:rounded-none px-3 py-1 transition-colors', + 'group relative my-2 flex select-none items-center justify-between rounded straight-corners:rounded-none px-3 py-1 transition-colors hover:cursor-default', isActive ? 'text-primary-subtle' : 'text-tint hover:bg-tint-hover hover:text-tint-strong'