Skip to content

Support engine262? #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leobalter opened this issue Jul 23, 2019 · 7 comments
Open

Support engine262? #75

leobalter opened this issue Jul 23, 2019 · 7 comments

Comments

@leobalter
Copy link

I'd like to have a pre-compiled engine262 available in jsvu. I would use it for projects like the test262.report, similarly to #73 and #72

https://github.com/engine262/engine262

Thanks!

@mathiasbynens
Copy link
Member

I'd like to have a pre-compiled engine262 available in jsvu

engine262 is not "compiled" though, so I'm not sure what it would mean to offer "precompiled" engine262 binaries. Perhaps using pkg to create standalone binaries?

I'm open to the idea, but at this point I'm not sure if it makes sense.

@devsnek @TimothyGu What do you think?

@devsnek
Copy link

devsnek commented Jul 23, 2019

I think I can generate js bundles. If you're running jsvu you have node so i think that should be enough.

@mathiasbynens
Copy link
Member

If you're running jsvu you have node so i think that should be enough.

But then again if you have node, you have npm, so why not just npm install -g engine262? @leobalter?

jsvu is all about getting easy access to JS engine binaries, without having to compile them from source yourself. For engine262 there is no real “binary” and so this doesn’t apply.

@devsnek
Copy link

devsnek commented Dec 1, 2019

engine262 can be installed from here now: https://github.com/engine262/engine262/packages/66778 or directly downloaded as a tar from https://api.engine262.js.org/download

if jsvu did want to support this, it could grab and unzip the tarball same as other engines.

@devsnek
Copy link

devsnek commented Jan 14, 2020

I think it would make more sense to include engine262 with jsvu. I'm not sure why there is a difference between downloading an engine262 build tar and a v8 build tar.

@mathiasbynens
Copy link
Member

mathiasbynens commented Jan 15, 2020

I'm not sure why there is a difference between downloading an engine262 build tar and a v8 build tar.

The difference is what I said above: the current engine262 tars don't include an actual binary.

jsvu makes it easier to install JS engine binaries so you don't have to compile them from source all the time. Conceptually, after installing an engine with jsvu, you can uninstall Node.js and npm and still have the binaries work, because they're standalone binaries. With engine262 this is not the case, because it's not a binary -- it's a JavaScript app that depends on Node.js at runtime.

I'd rather not add non-binaries to jsvu, since they can already easily be installed without the need to compile from source. E.g. for packages published to npm (like engine262 should be), you'd use npm install.

@devsnek
Copy link

devsnek commented Jan 15, 2020

@mathiasbynens is the idea that anything with a runtime dependency that is not included in the release package should not be distributed by jsvu?

engine262 does have a compile step (because the spec has macros), so it seemed like jsvu ("jsvu makes it easy to install recent versions of various JavaScript engines without having to compile them from source") was the right choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants