Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output File not Valid XML: <_ expectation set> #23

Open
WardLT opened this issue Sep 20, 2017 · 1 comment
Open

Output File not Valid XML: <_ expectation set> #23

WardLT opened this issue Sep 20, 2017 · 1 comment

Comments

@WardLT
Copy link

WardLT commented Sep 20, 2017

I have been having some trouble parsing output files from qbox/qball with python's XML parsers. The offending lines have attributes without values in them, such as:

<FORKTD expectation set>

In order parse these files I have been adding some extra underscores (e.g., <FORKTD expectation set> to <FORKTD_expectation_set>).

My questions for you are:

  1. Do you also view the inability to read the output files with Python as an issue?
  2. Is adding underscores to the output statements of offending tags an acceptable fix? I am not a qball user, so I'm not 100% sure what these tags mean
  3. Do you mind if I attempt to make the changes? I see that these lines are output in EhrenSampleStepper.C. Am I missing anywhere?
@xavierandrade
Copy link
Collaborator

xavierandrade commented Sep 20, 2017

Thanks for your report.

  1. Yes, the output should be valid XML, so this is a bug.
  2. Probably it's the best solution, there is no standard to follow so a valid tag name is enough.
  3. A pull request or a patch is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants