Skip to content

Fail to change resolution from render arguments #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ponmike92 opened this issue Aug 14, 2020 · 3 comments
Closed

Fail to change resolution from render arguments #282

ponmike92 opened this issue Aug 14, 2020 · 3 comments
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Comments

@ponmike92
Copy link

macOS Catalina, I installed manim as package
fails when I try to change resolution settings

manim basic.py SquareToCircle -plr 700,700

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.7/bin/manim", line 5, in <module>
    from manim.__main__ import main
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/manim/__init__.py", line 4, in <module>
    from .config import config
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/manim/config.py", line 97, in <module>
    config = _parse_config(config_parser, args)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/manim/config.py", line 46, in _parse_config
    config["camera_config"].update({"pixel_height": height, "pixel_width": width})
KeyError: 'camera_config'
@Aathish04 Aathish04 added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Aug 14, 2020
@leotrs
Copy link
Contributor

leotrs commented Aug 15, 2020

@ponmike92 thank you for reporting this issue. We have been working on fixing it since you first reported it, I just forgot to post something here!

@Aathish04 I think this has been fixed, no? Or are we waiting on #283?

@Aathish04
Copy link
Member

Aathish04 commented Aug 15, 2020

I wanted a concrete decision on #283 before I began removing stuff left right and center, but I'll try and see if i can fix this.

Also doesn't help that I've got exams next week soo... if anyone else wants to take this up that's fine by me. (but please tell me if you want to work on this, so I don't :) )

@leotrs leotrs closed this as completed in 63692a1 Aug 23, 2020
@leotrs
Copy link
Contributor

leotrs commented Aug 23, 2020

@ponmike92 apologies for the delay. This has now been fixed in the latest master. Please try again and let us know if the error persists!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
Development

No branches or pull requests

3 participants