Skip to content

Failing tests due to Cairo 1.17.8 subpixel antialiasing update #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrDiver opened this issue Aug 3, 2023 · 1 comment · Fixed by #3416
Closed

Failing tests due to Cairo 1.17.8 subpixel antialiasing update #3310

MrDiver opened this issue Aug 3, 2023 · 1 comment · Fixed by #3416
Assignees
Labels
breaking changes This PR introduces breaking changes cairo issue:bug Something isn't working... For use in issues

Comments

@MrDiver
Copy link
Collaborator

MrDiver commented Aug 3, 2023

In Cairo Version 1.17.8 there was new subpixel antialiasing introduced based on the changes in 1.17.4. This breaks the behavior of manim because it changes the output of the tests so many tests will fail due to different pixels at the border of mobjects.

One solution might be to increase the error ratio or update the test data. This will most likely break the tests for people using the older cairo version.

@MrDiver MrDiver added breaking changes This PR introduces breaking changes issue:bug Something isn't working... For use in issues cairo labels Aug 3, 2023
@MrDiver MrDiver added this to Dev Board Aug 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Aug 3, 2023
@naveen521kk
Copy link
Member

naveen521kk commented Oct 2, 2023

FYI, there's a new stable release of Cairo out now https://cairographics.org/news/cairo-1.18.0/

also see #3399 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes This PR introduces breaking changes cairo issue:bug Something isn't working... For use in issues
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants