Skip to content

Follow-up to #562 -- bug with Transform / Mobject.become #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
behackl opened this issue Oct 24, 2020 · 0 comments · Fixed by #614
Closed

Follow-up to #562 -- bug with Transform / Mobject.become #610

behackl opened this issue Oct 24, 2020 · 0 comments · Fixed by #614
Assignees
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Comments

@behackl
Copy link
Member

behackl commented Oct 24, 2020

git bisect says that merging #562 introduced a problem with Mobject.become: The example

class FadeInAndOut(Scene):
    def construct(self):
        square = Square(color=BLUE).shift(2 * UP)
        annotation = Text("Fade In", height=0.8)
        self.add(annotation)
        self.play(FadeIn(square))

        annotation.become(Text("Fade Out", height=0.8))
        self.add(annotation)
        self.play(FadeOut(square))

from our documentation renders as

FadeInAndOut

Same thing if the call to become is replaced by playing a Transform animation; the old text is simply kept on screen.

Originally posted by @behackl in #562 (comment)

@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
2 participants