Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] LCD_LANGUAGE does not work anymore #27728

Closed
1 task done
Amachete opened this issue Mar 8, 2025 · 2 comments · May be fixed by #27729
Closed
1 task done

[BUG] LCD_LANGUAGE does not work anymore #27728

Amachete opened this issue Mar 8, 2025 · 2 comments · May be fixed by #27729

Comments

@Amachete
Copy link

Amachete commented Mar 8, 2025

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Hello

I am updating with latest version of Marlin and the translations on the LCD does not work anymore, I have tried several revisions. texts are only in english.

Bugfix (latest): Does not work
release-2.1.3-beta2: Does not work
release-2.1.3-beta1: Does not work

Marlin-2.1.2.5: WORKS

THe only thing I change to build and upload to see it this works

#define REPRAP_DISCOUNT_SMART_CONTROLLER

#define LCD_LANGUAGE es//en

If you need something else let me know.

Bug Timeline

No response

Expected behavior

LCD texts translated to my language es (spanish)

Actual behavior

LCD texts only in English

Steps to Reproduce

No response

Version of Marlin Firmware

latests

Printer model

p3steel

Electronics

ramps

LCD/Controller

reprapcontroller

Other add-ons

No response

Bed Leveling

ABL Bilinear mesh

Your Slicer

Prusa Slicer

Host Software

SD Card (headless)

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Marlin_BUGFIX_P3Steel.zip

@ellensp
Copy link
Contributor

ellensp commented Mar 8, 2025

In Bugfix 2.1.x in file Marlin/src/inc/Conditionals-2-LCD.h is

#if NONE(HAS_MARLINUI_U8GLIB, HAS_TFT_LVGL_UI, TFT_COLOR_UI, DGUS_LCD_UI_E3S1PRO)
  #undef LCD_LANGUAGE
#endif

this is removing LCD_LANGUAGE for your display

As a quick test remove those 3 lines (this works for me in the SIM)

@ellensp
Copy link
Contributor

ellensp commented Mar 8, 2025

A PR to fix this has been created

@ellensp ellensp closed this as completed Mar 8, 2025
@thisiskeithb thisiskeithb linked a pull request Mar 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants