Skip to content

Store workspace id in mergin.json #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uclaros opened this issue Nov 21, 2022 · 3 comments
Closed

Store workspace id in mergin.json #151

uclaros opened this issue Nov 21, 2022 · 3 comments

Comments

@uclaros
Copy link
Contributor

uclaros commented Nov 21, 2022

If renaming of workspaces is to be implemented, we will need to stop relying on the namespace stored in mergin.json and use the workspace id. We should probably start storing it from the beginning even if we don't use it yet.
Maybe also store the server? Or even list of pairs server - workspace id?

@wonder-sk
Copy link
Contributor

Probably it would be good if the project info endpoint included:

  • project ID
  • server URL
  • workspace ID

That way we would get all that included in mergin.json automatically (rather than adding that extra within the client), and it could be useful also elsewhere (e.g. when trying to link an existing project checkout)

@wonder-sk
Copy link
Contributor

Project ID gets stored in >= 0.8.0 ... see #154

@wonder-sk
Copy link
Contributor

We have project ID and workspace ID stored in mergin.json since #83. The server URL is not stored anywhere at this point, but this could be added later if needed (working in the same way as the c++ client) - possibly in a separate file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants