Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use relative path in # include #1194

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

carsonRadtke
Copy link
Collaborator

Reverts commit that changes #include "assert" -> #include "gsl/assert". This change is necessary in order to comply with CppCoreGuideline's SF.12. Now we do #include "./assert".

fixes #1188

Reverts commit that changes #include "assert" -> #include "gsl/assert".
This change is necessary in order to comply with CppCoreGuideline's
SF.12. Now we do #include "./assert".
@carsonRadtke carsonRadtke merged commit 4742bc1 into microsoft:main Feb 12, 2025
83 checks passed
@carsonRadtke carsonRadtke deleted the use-relative-includes branch February 12, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#include statements violate SF.12
1 participant