Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX for CRAN - reduce CPU use in test cases #18

Open
MikeKSmith-Pfizer opened this issue Feb 8, 2024 · 2 comments
Open

FIX for CRAN - reduce CPU use in test cases #18

MikeKSmith-Pfizer opened this issue Feb 8, 2024 · 2 comments

Comments

@MikeKSmith-Pfizer
Copy link
Collaborator

Forwarded message from CRAN


Dear maintainer,

your package MSToolkit does not comply with the CRAN policies:

In your tests, you make use of as many (virtual) CPU cores as available in the current machine, i.e. with 32 parallel processes in the unit tests for the most recent Windows check machine.

This does not make any sense and wastes CRAN resources (and for some other reasons cause that the package fails the Windows checks rather frequently).

Please follow the CRAN policies and do not use more than 2 processes!

We expect an update rather quickly. It took me quite soem time to investigate the problem since you are using some obfuscating unit check framework.

Best,
Uwe Ligges

@MikeKSmith-Pfizer
Copy link
Collaborator Author

We should explicitly use grid = FALSE option in analyzeData( ) for testing / example cases to ensure that we don't hog CPUs on CRAN test servers.

@MikeKSmith-Pfizer
Copy link
Collaborator Author

Line 240 in analyzeData function checks for number of cores and limits to 2 if on CRAN(?) Presumably this isn't working though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant