Skip to content

Commit 5c0a1bc

Browse files
add missing check for disabled output files
AR would AR abort if --out-prefix was used while demultiplexing
1 parent 83f1ce5 commit 5c0a1bc

File tree

6 files changed

+51
-1
lines changed

6 files changed

+51
-1
lines changed

src/demultiplexing.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,10 @@ processes_unidentified::processes_unidentified(const userconfig& config,
233233
m_output.set_file(read_type::mate_1, output.unidentified_1);
234234
m_output.set_file(read_type::mate_2, output.unidentified_2);
235235

236-
m_output.set_step(read_type::mate_1, output.unidentified_1_step);
236+
if (output.unidentified_1_step != output_files::disabled) {
237+
m_output.set_step(read_type::mate_1, output.unidentified_1_step);
238+
}
239+
237240
if (output.unidentified_1_step != output.unidentified_2_step &&
238241
output.unidentified_2_step != output_files::disabled) {
239242
m_output.set_step(read_type::mate_2, output.unidentified_2_step);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
sample_1 CTTGCCCT ACGTTATT
2+
sample_2 CGCCGATG TGCACGGG
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
@read_150_1/1
2+
CTTGGGTACTCAGCCTTAGGGTACCACATAGAGTTATCTTATATATTATAATTGCTCTTTTAACATAATTTTAAAAAATTTATATTAAACTTTCTCTGTT
3+
+
4+
HHHFFFFBBDGGGGGHHHHHGGFCDHGEE<@;+@C792A.CEEGGFFFFDEFGFHHHH@C2;@F;EDDHFDCCC@.DEEEG=BGEDC5>:=2@GFHHHFF
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
@read_150_1/2
2+
AGAAACCACAGTGACTTAAACAGAGAAAGTTTAATATAAATTTTTTAAAATTATGTTAAAAGAGCAATTATAATATATAAGTTAACTCTATGTGGTACCC
3+
+
4+
HHHFFHHHHHHGFBGHHEFBDG?B=GHHFGFHFHHHHHHHFBFHHHHHGGEEG=DGGGGCHHHHHHHGEA%5ADHHHH=G&&*>><EHHFE@=:51'*5?
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"description": "Missing check resulting in attempted to write disabled read-type",
3+
"arguments": [
4+
"--out-prefix",
5+
"/dev/null",
6+
"--barcode-list",
7+
"barcodes.txt"
8+
],
9+
"files": {
10+
"input_1": [
11+
"input_1.fastq"
12+
],
13+
"input_2": [
14+
"input_2.fastq"
15+
],
16+
"barcodes": [
17+
"barcodes.txt"
18+
]
19+
}
20+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{
2+
"description": "Missing check resulting in attempted to write disabled read-type",
3+
"arguments": [
4+
"--out-prefix",
5+
"/dev/null",
6+
"--barcode-list",
7+
"barcodes.txt"
8+
],
9+
"files": {
10+
"input_1": [
11+
"input_1.fastq"
12+
],
13+
"barcodes": [
14+
"barcodes.txt"
15+
]
16+
}
17+
}

0 commit comments

Comments
 (0)