Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use the PreQC obs filter? #307

Open
guoqing-noaa opened this issue Mar 3, 2025 · 6 comments
Open

Can we use the PreQC obs filter? #307

guoqing-noaa opened this issue Mar 3, 2025 · 6 comments

Comments

@guoqing-noaa
Copy link
Collaborator

guoqing-noaa commented Mar 3, 2025

NCAR uses the following simple filter to reject all obs with a qcflag larger than 3

filter: PreQC
maxvalue: 3

Could we use it as well?

Right now, we use the following filter corresponding to this capability:

filter: RejectList
apply at iterations: 0,1
where:
- variable: ObsType/airTemperature
  is_in: 133
- variable: QualityMarker/airTemperature
  is_in: 4-15
action:
  name: reduce obs space
@guoqing-noaa
Copy link
Collaborator Author

@delippi @SamuelDegelia-NOAA @spanNOAA

Is there a reason why we are not able to use the PreQc filter?

@delippi
Copy link
Collaborator

delippi commented Mar 3, 2025

It is my understanding that PreQC is deprecated. It was changed to QualityMarker. You would either have to update the filters or have PreQC in the IODA file. Again, it is now called QualityMarker and that isn't something they want to change back. We do have PreQC in the GSI-IODA which is why I'm thinking most people are still able to use it. It seems like they haven't moved on to bufr2ioda obs.

I don't think there is any benefit of using the PreQC filter over what we do now. They both would do the same thing.

@delippi
Copy link
Collaborator

delippi commented Mar 3, 2025

Also, check the latest RDASApp yamls. I've made changes such as RejectList --> Perform Action. There are various other things as well. Probably won't impact results much though.

@guoqing-noaa
Copy link
Collaborator Author

Thanks for the information! @delippi

@guoqing-noaa
Copy link
Collaborator Author

Also, check the latest RDASApp yamls. I've made changes such as RejectList --> Perform Action. There are various other things as well. Probably won't impact results much though.

Curious why we want to change from RejectList to Perform Action?

@delippi
Copy link
Collaborator

delippi commented Mar 10, 2025

Also, check the latest RDASApp yamls. I've made changes such as RejectList --> Perform Action. There are various other things as well. Probably won't impact results much though.

Curious why we want to change from RejectList to Perform Action?

Both will do the same thing. I think the reason I had changed it was because I had some yamls using RejectList and others using Perform Action and I had just went with Perform Action. I believe RejectList can only reject obs, so it might be the more direct way to do this. Perform Action is more flexible and can do any action (for debugging purposes it could be helpful), but we probably have all the problems worked out by now. We can use either one. It doesn't make any real difference to me.

The main reason I was pointing that out was that the yamls being used were a slightly older version than what we had in RDASApp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants