From 5c5f3073d179aafc80fec4f34c829f6bdce8dc80 Mon Sep 17 00:00:00 2001 From: Rosen Vladimirov <rosen-vladimirov@users.noreply.github.com> Date: Tue, 2 May 2017 09:10:10 +0300 Subject: [PATCH 1/3] Fix working with 32 bit Node on Windows (#2752) During detecting devices, CLI will try to check if there are iOS devices. However the ios-device-lib has an issue in version 0.4.0 and it fails that the binary cannot be found. So use latest version of the lib, where the issue is fixed. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b46a6bfb23..25c695373e 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "glob": "^7.0.3", "iconv-lite": "0.4.11", "inquirer": "0.9.0", - "ios-device-lib": "0.4.0", + "ios-device-lib": "0.4.1", "ios-mobileprovision-finder": "1.0.9", "ios-sim-portable": "~2.0.0", "lockfile": "1.0.1", From b2301d1083991c68a4939ae4eb810cf0eb514661 Mon Sep 17 00:00:00 2001 From: Rosen Vladimirov <rosen-vladimirov@users.noreply.github.com> Date: Tue, 2 May 2017 22:07:42 +0300 Subject: [PATCH 2/3] Fix `tns debug ios --justlaunch` (#2758) When `--justlaunch` flag is passed, CLI automatically disposes the `ios-device-lib` after execution of the command. However this closes all opened device sockets and breaks the debug command. So whenever you try `tns debug ios --justlaunch [--chrome]`, the debug application (NativeScript Inspector) or Chrome DevTools is unable to connect to device socket and fails with error. Fix this by keeping the `ios-device-lib` alive whenever we try debug for ios. This way the debug application will be able to connect to the device. NOTE: `tns debug ios --justlaunch [--chrome]` cannot release the terminal as it has to keep the ios-device-lib alive. --- lib/commands/debug.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/commands/debug.ts b/lib/commands/debug.ts index 62e4dc312b..e0ac47dd3a 100644 --- a/lib/commands/debug.ts +++ b/lib/commands/debug.ts @@ -103,7 +103,11 @@ export class DebugIOSCommand extends DebugPlatformCommand { $platformsData: IPlatformsData, $iosDeviceOperations: IIOSDeviceOperations) { super($iOSDebugService, $devicesService, $injector, $devicePlatformsConstants, $config, $usbLiveSyncService, $debugDataService, $platformService, $projectData, $options, $platformsData, $logger); - $iosDeviceOperations.setShouldDispose(this.$options.justlaunch); + // Do not dispose ios-device-lib, so the process will remain alive and the debug application (NativeScript Inspector or Chrome DevTools) will be able to connect to the socket. + // In case we dispose ios-device-lib, the socket will be closed and the code will fail when the debug application tries to read/send data to device socket. + // That's why the `$ tns debug ios --justlaunch` command will not release the terminal. + // In case we do not set it to false, the dispose will be called once the command finishes its execution, which will prevent the debugging. + $iosDeviceOperations.setShouldDispose(false); } public async canExecute(args: string[]): Promise<boolean> { From b16ad079acf38f9a411ccac883adf5d5269201b3 Mon Sep 17 00:00:00 2001 From: pkoleva <pavlina.koleva@telerik.com> Date: Wed, 3 May 2017 15:53:18 +0300 Subject: [PATCH 3/3] Updated Changelog for 3.0.0 release (#2759) Added 3.0.0 changelog items --- CHANGELOG.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8eac90c0e6..7c355b7f02 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,21 @@ NativeScript CLI Changelog ================ +3.0.0 (2017, May 3) +== + +### Fixed + +* [Fixed #2500](https://github.com/NativeScript/nativescript-cli/issues/2500): Debug on device does not sync file changes +* [Fixed #2639](https://github.com/NativeScript/nativescript-cli/issues/2639): Build continues after gradle build fails +* [Fixed #1882](https://github.com/NativeScript/nativescript-cli/issues/1882): Run/debug commands should not try to deploy on connected but not paired devices +* [Fixed #2673](https://github.com/NativeScript/nativescript-cli/issues/2673): `tns device ios` does not list real devices if simulator is running. +* [Fixed #2685](https://github.com/NativeScript/nativescript-cli/issues/2685): `tns run ios` starts iOS Simulator even if physical iOS device is attached +* [Fixed #2661](https://github.com/NativeScript/nativescript-cli/issues/2661): Adding new files during livesync doesn't succeed on iOS Devices +* [Fixed #2650](https://github.com/NativeScript/nativescript-cli/issues/2650): Release Build Android error: gradlew.bat failed with exit code 1 When Path contains Space +* [Fixed #2125](https://github.com/NativeScript/nativescript-cli/issues/2125): NativeScript setup script fails on Mac +* [Fixed #2697](https://github.com/NativeScript/nativescript-cli/issues/2697): App_Resources being copied into app RAW + 3.0.0-RC.1 (2017, March 29) ==