Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons not showing in the update window #44

Closed
victorct opened this issue Mar 23, 2018 · 16 comments
Closed

Buttons not showing in the update window #44

victorct opened this issue Mar 23, 2018 · 16 comments

Comments

@victorct
Copy link

victorct commented Mar 23, 2018

I have installed the library in my C# project through NuGet, but every time there is an update the buttons to start downloading, to skip, or to remind the user to download later do not show up in the window, making the library impossible to use.

Here is an example of my code:

var sparkle = new Sparkle(
                Misc.Util.getUrl() + "/core/windows/agent/appcast.xml",
                Properties.Resources.Befective,
                NetSparkle.Enums.SecurityMode.Unsafe
            );
sparkle.StartLoop(true,true);

how the window looks

@victorct
Copy link
Author

victorct commented Mar 23, 2018

I have already tried resizing the window, and not success, I cloned the project and opened the Designer of that window, and the buttons are not even inside the panel, they are outside.

@victorct victorct changed the title Buttons not showing in the update windows Buttons not showing in the update window Mar 23, 2018
@Deadpikle
Copy link
Member

Hi @victorct ! Thanks for the report. Not sure what's going on off the top of my head, but I wanted to acknowledge the report and let you know that I'll look at it ASAP. I haven't run into this issue myself, including in the designer view, so that's odd. You wouldn't happen to be using a non-English language for Sparkle, would you? (I've done no research/work on this fork to make sure that the translations work properly. 😅)

@Deadpikle
Copy link
Member

Deadpikle commented Mar 25, 2018

In a quick look at the code, I see nothing that would be hiding the update available button at the very least. My designer view looks fine. The report of cloning the project and having it not work is also strange. I noticed you're running in VMWare Fusion. Any chance this could be causing strange issues?

Could you please tell me what version of .NET you're using? It looks like the sample projects are broken for some reason (grumble grumble --- I logged this in #45) or I'd ask you to try running those too.

I will do what I can to look at this Sunday evening EDT, but I might not get to it until Monday evening EDT.

@Deadpikle
Copy link
Member

@victorct I fixed the sample projects. Do you mind pulling the latest code and giving one of the samples a try, say, NetSparkleTestAppWPF, to see if the samples work? I was also unable to find any localization related bugs, as the current localizations just modify strings. I'm definitely not seeing the same things you are if the update buttons are outside the current form. Please provide me with the .NET version you are using and any other helpful info (your OS version [in case some version of Windows 10 is broken], etc.) so that I can help you with this issue! Thanks. :)

@victorct
Copy link
Author

Hello @Deadpikle I didn't have time to do what you need yet, I will do it today and give you the info (about the tests and the OS, .NET framework etc.) later.

I will keep you posted.

@Deadpikle
Copy link
Member

Deadpikle commented Mar 27, 2018 via email

@ndreisg
Copy link

ndreisg commented Jun 12, 2019

While the dialog looks fine on my machine, one of my colleagues was recently able to reproduce this strange issue on his machine.
I will try to get Visual Studio on the affected machine and gain some more insight in the next few days.

@ndreisg
Copy link

ndreisg commented Jun 13, 2019

First thing I found out:
On the affected machine the default (recommended) scaling factor in the windows display settings is 150%.
When I set it to 100% the buttons are visible.
Though it is still not reproducible on my machine when I set scaling to 150%.

@ndreisg
Copy link

ndreisg commented Jun 13, 2019

Enabling the AutoSize property on the buttons fixed it.

@Deadpikle
Copy link
Member

@ndreisg Thanks for looking into this! I'll try to push out a bug fix update in the next few days. 🎈

@Deadpikle
Copy link
Member

Deadpikle commented Jun 23, 2019

@ndreisg
@victorct
I've uploaded a 0.16.5 build to NuGet with a bunch of the buttons set to AutoSize = true. Please let me know if this fixes your issue, as I've been unable to replicate the bug on my machine.

@ndreisg
Copy link

ndreisg commented Jun 24, 2019

With the new 0.16.5 version my dialog is much bigger (HideReleaseNotes = true)
Also interesting: I can only increase the size of the dialog at runtime.

@ndreisg
Copy link

ndreisg commented Jun 24, 2019

Problem seems to be caused by AutoSize = true on the dialog itself (the root Form element)
see my comment on the commit.

@Deadpikle
Copy link
Member

I hear you. Give me a few minutes, and I'll remove the AutoSize = true on the dialog.

@Deadpikle
Copy link
Member

OK, sorry about that. I've pushed 0.16.6 and commit 3920eb4 to remove AutoSize = true on the dialogs.

@Deadpikle
Copy link
Member

@victorct @ndreisg Are things working out for you? I never heard from you if things are working ok. I will close this issue, assuming it's resolved, but please comment here if things pop up again or are not working. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants