Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using tags as a Parameter name breaks flow. #1735

Closed
saikonen opened this issue Feb 15, 2024 · 1 comment · Fixed by #1736
Closed

Using tags as a Parameter name breaks flow. #1735

saikonen opened this issue Feb 15, 2024 · 1 comment · Fixed by #1736

Comments

@saikonen
Copy link
Collaborator

original discussion here: https://outerbounds-community.slack.com/archives/C02116BBNTU/p1707942631741849

cause is due to the calls to obj.flow._set_constants(obj.graph, kwargs) in cli.py, as tags is an argument for the function, so it is not a part of the trailing kwargs that is passed to _set_constants.

List of affected (restricted) parameter names that are not covered, and are affected by the same bug:

    # Not Covered
    tags = Parameter("tags")
    decospecs = Parameter("decospecs")
    run_id_file = Parameter("run_id_file")
    maxworkers = Parameter("max_workers")
    maxnumsplits = Parameter("max_num_splits")
    maxlogsize = Parameter("max_log_size")
    user_namespace = Parameter("user_namespace")
    obj = Parameter("obj")
@saikonen
Copy link
Collaborator Author

There are two remedies for the issue as I see it. Either we prefix the arguments to the cli functions with _ so we can support common names for parameters such as tags.

The more straightforward way is to simply update the reserved params list, which would seem like an acceptable compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant