This repository was archived by the owner on Apr 27, 2024. It is now read-only.

Language Mismatch when no lyrics are found. #53

Closed

SurajBhari opened this issue Sep 14, 2022 · 4 comments · Fixed by #54

Contributor

SurajBhari commented Sep 14, 2022

system language is "en" but when no lyrics are found it writes in wrong language. other then the one specified
example

Contributor Author

SurajBhari commented Sep 14, 2022

ps. this is different from "No lyrics available"
test subject - https://www.youtube.com/watch?v=D2STcRnJnGw

NyaomiDEV closed this as not planned

Owner

NyaomiDEV commented Sep 14, 2022 •

edited

Loading

The issue here is with NetEase Lyrics serving you lyrics for a song that probably is not what you expect, and on top of that the song it's expecting to be is also an instrumental one.

This has no cause within Sunamu, as the strings are reported by NetEase which is a Chinese service.

Therefore, this issue is invalid.

Contributor Author

SurajBhari commented Sep 14, 2022

Then allowing to not use specific lyrics provider would be nice ?

Owner

NyaomiDEV commented Sep 14, 2022 •

edited

Loading

Make a PR for it, if you will. I don't have the time nor am I considering maintaining this project even further.

Read: #28

SurajBhari mentioned this issue

Functionality to disable specific lyrics provider #54

Merged

NyaomiDEV closed this as completed in #54

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.