Skip to content

consider adding a CODEOWNERS file to this repository #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baywet opened this issue Dec 14, 2023 · 5 comments
Closed

consider adding a CODEOWNERS file to this repository #3473

baywet opened this issue Dec 14, 2023 · 5 comments
Assignees

Comments

@baywet
Copy link
Contributor

baywet commented Dec 14, 2023

A common challenge on pull requests is to know who needs to approve, and have them receive notifications to the pull request moves forward.
Adding a codeowners file and updating the branch policies would help resolve this.
I'll need a bit more input from the team here, but here are the notes from the meeting:

2 TSC members should approve anything for the "versions" directory.
2 people with the contrib permission should approve anything anywhere else.

Do we have github teams for those two populations today?
Any other rule I might be missing here?

Thanks for the input @earth2marsh @lornajane @darrelmiller @handrews

@darrelmiller
Copy link
Member

We have "@OAI/tsc" and "@OAI/triage" teams that I think fit those two groups.

@lornajane
Copy link
Contributor

We might want to rename the not-TSC team since "triage" describes the GitHub role that these people have. Alternatively: Introduce a "maintainers" team for the people who have that level of access, which I think we discussed giving to more people - and this allows us to keep the triage team as a starter role for people who want to help but might not be ready for merge commit rights yet.

@darrelmiller
Copy link
Member

Agreed. I tried creating a maintainers team but the Teams mechanism in GitHub seems to be a hierarchy. Seems like we need to think about how we want to organize the structure to make it manageable.

@baywet
Copy link
Contributor Author

baywet commented Dec 14, 2023

@darrelmiller meaning you're not able to create @OAI/maintainers ?

@lornajane
Copy link
Contributor

Fixed by #3489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@lornajane @darrelmiller @baywet and others