Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are not shown for leaves without OTTs #903

Open
davidebbo opened this issue Nov 17, 2024 · 1 comment
Open

Images are not shown for leaves without OTTs #903

davidebbo opened this issue Nov 17, 2024 · 1 comment
Labels

Comments

@davidebbo
Copy link
Collaborator

Looking at the code, it may have been a deliberate decision, but it is not clear why:

images_by_ott_query_res = iucn_query_res = reservations_res = None #don't bother getting images for nodes without otts

This is a problem with the extinct tree, which has some leaves for which no OTT exists, and hence get no image. e.g.

  • Globidens alambamensis
  • Fraserosphenodon latidens
  • Anshunsaurus huangnihensis
@hyanwong
Copy link
Member

I think this was because there weren't that many of them, so I didn't code the extra path (and perhaps was worried that it would slow down the query). I suspect it can be coded to be performant though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants