Skip to content

data_dir=/tmp from config editor cannot become stored and used as expected #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReimarBauer opened this issue Mar 20, 2025 · 2 comments
Assignees
Labels
bug Something isn't working msui
Milestone

Comments

@ReimarBauer
Copy link
Member

Using /tmp for the data_dir in the config editor will store this into the msui_settings.json

"data_dir": "/tmp",

but display it as ~/mssdata

Image

The bug is located in the comparison in https://github.com/Open-MSS/MSS/blob/develop/mslib/utils/config.py#L672

we recognized match_type has a bug
type(match_type("~/mss")) == StrType while type(c.match_type("/mss")) == FilepathType

This limits currently the path to have a startwith tilde or an fs url definition.

We need a comparison which allows all PyFileSystem2 path definitions. What we see in the editor should be the value which we stored in the file.

@ReimarBauer ReimarBauer added bug Something isn't working msui labels Mar 20, 2025
@ReimarBauer ReimarBauer added this to the 10.0.2 milestone Mar 20, 2025
@ReimarBauer
Copy link
Member Author

The fix needs to go to stable branch.

@levi178u
Copy link
Contributor

@ReimarBauer I have studied the code base and figured out a solution for this, pls assign me this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working msui
Projects
None yet
Development

No branches or pull requests

2 participants