Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning sneaks in variables that are not supported when deploying yaml file from cli #3053

Open
christad92 opened this issue Mar 21, 2025 · 0 comments
Labels
bug Newly identified bug

Comments

@christad92
Copy link

New project-level features add new variables to the project.yaml. When this happens, the CLI must be updated to support the variables so that cli operations can run without breaking. This is a recent report of this bug.

We think fixing this will be expensive but we have a few ideas on how we might pay the debt sustainably.

Potential solutions

  1. Add compatibility to documentation to help users know which cli version is compatible with lightning version.
  2. Update the extraneous parameter error message to suggest updating cli- version.
  3. Add a sentry alert log for extraneous parameter error
  4. Limit the variables exported by project.yaml per time based on CLI compatibility. "don't export concurrency and collections if you are on this CLI version because deploy will break."
@christad92 christad92 added the bug Newly identified bug label Mar 21, 2025
@christad92 christad92 moved this to Product Backlog in v2 Mar 21, 2025
@christad92 christad92 added this to v2 Mar 21, 2025
@christad92 christad92 moved this from Product Backlog to Ready in v2 Mar 21, 2025
@christad92 christad92 moved this from Ready to Product Backlog in v2 Mar 21, 2025
@taylordowns2000 taylordowns2000 moved this from Product Backlog to Icebox in v2 Mar 25, 2025
@taylordowns2000 taylordowns2000 moved this from Icebox to Product Backlog in v2 Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant