Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Error publishing profile #547

Closed
sparrowDom opened this issue Sep 21, 2018 · 8 comments
Closed

Error publishing profile #547

sparrowDom opened this issue Sep 21, 2018 · 8 comments
Assignees
Labels
bug Something isn't working as intended dapp origin.js

Comments

@sparrowDom
Copy link
Member

sparrowDom commented Sep 21, 2018

When you change your profile information and/or attestations and try to publish them the following error with no metamask confirmation is thrown:

Returned values aren't valid, did it run Out of Gas?
    at s.decodeParameters (app.7f507472.js:6371)
    at s.decodeLog (app.7f507472.js:6371)
    at Object.d._decodeEventABI (app.7f507472.js:6377)
    at app.7f507472.js:1345
    at Array.map (<anonymous>)
    at c.formatOutput (app.7f507472.js:1345)
    at a (app.7f507472.js:1345)
    at app.7f507472.js:15831
    at inpage.js:1
    at inpage.js:1

(this happens on staging environment on Rinkeby)

@sparrowDom
Copy link
Member Author

Here people are having the same problem with similar stack traces: web3/web3.js#1916

@sparrowDom sparrowDom added bug Something isn't working as intended dapp origin.js labels Sep 21, 2018
@franckc
Copy link
Contributor

franckc commented Sep 21, 2018

@nick @tyleryasaka Any idea what the issue could be ?

Also CCing @micahalcorn

@tyleryasaka
Copy link
Contributor

web3's estimateGas method doesn't return sufficient estimates for attestations, so we are currently hard coding the gas amounts. Perhaps we just need to increase these amounts a bit.

https://github.com/OriginProtocol/origin-js/blob/master/src/contractInterface/users/v00_adapter.js#L130

@franckc
Copy link
Contributor

franckc commented Sep 21, 2018

@tyleryasaka: @sparrowDom is done for the day since it is already late in Europe... Would you be ok working on a fix this afternoon ? thanks in advance.

@tyleryasaka
Copy link
Contributor

Ok I don't think it's the problem I suggested in the previous comment.

Confirmed the error is coming from this line: https://github.com/OriginProtocol/origin-js/blob/staging/src/contractInterface/users/v00_adapter.js#L159

@tyleryasaka
Copy link
Contributor

Reading through the issue @sparrowDom linked to, I'm not sure what we can do about this. We could roll back web3 to beta.34 but that would introduce breaking changes.

This is not a bug on our end. This is what happens when we try to use beta software in production. 😬

@tyleryasaka
Copy link
Contributor

The other possibility is that we can change our event signature to not have all indexed parameters. See web3/web3.js#1916 (comment)

@franckc
Copy link
Contributor

franckc commented Sep 21, 2018

This fix should help with this issue: OriginProtocol/origin-js#530

@franckc franckc closed this as completed Sep 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working as intended dapp origin.js
Projects
None yet
Development

No branches or pull requests

3 participants