Avoid string concatentation to template strings

ChadKillingsworth · ChadKillingsworth · commit 0e6daa703ccc · 2019-01-30T11:01:43.000-06:00
diff --git a/lib/elements/array-selector.html b/lib/elements/array-selector.html
@@ -199,13 +199,13 @@
           let sidx = 0;
           this.__selectedMap.forEach(idx => {
             if (idx >= 0) {
-              this.linkPaths(`${JSCompiler_renameProperty('items', this)}.` + idx, `${JSCompiler_renameProperty('selected', this)}.` + sidx++);
+              this.linkPaths(`${JSCompiler_renameProperty('items', this)}.${idx}`, `${JSCompiler_renameProperty('selected', this)}.${sidx++}`);
             }
           });
         } else {
           this.__selectedMap.forEach(idx => {
-            this.linkPaths(JSCompiler_renameProperty('selected', this), `${JSCompiler_renameProperty('items', this)}.` + idx);
-            this.linkPaths(JSCompiler_renameProperty('selectedItem', this), `${JSCompiler_renameProperty('items', this)}.` + idx);
+            this.linkPaths(JSCompiler_renameProperty('selected', this), `${JSCompiler_renameProperty('items', this)}.${idx}`);
+            this.linkPaths(JSCompiler_renameProperty('selectedItem', this), `${JSCompiler_renameProperty('items', this)}.${idx}`);
           });
         }
       }
@@ -260,7 +260,7 @@
       }
 
       __selectedIndexForItemIndex(idx) {
-        let selected = this.__dataLinkedPaths[`${JSCompiler_renameProperty('items', this)}.` + idx];
+        let selected = this.__dataLinkedPaths[`${JSCompiler_renameProperty('items', this)}.${idx}`];
         if (selected) {
           return parseInt(selected.slice(`${JSCompiler_renameProperty('selected', this)}.`.length), 10);
         }

Original file line number	Diff line number	Diff line change
`@@ -199,13 +199,13 @@`
`199`	`199`	`let sidx = 0;`
`200`	`200`	`this.__selectedMap.forEach(idx => {`
`201`	`201`	`if (idx >= 0) {`
`202`		- this.linkPaths(`${JSCompiler_renameProperty('items', this)}.` + idx, `${JSCompiler_renameProperty('selected', this)}.` + sidx++);
	`202`	+ this.linkPaths(`${JSCompiler_renameProperty('items', this)}.${idx}`, `${JSCompiler_renameProperty('selected', this)}.${sidx++}`);
`203`	`203`	`}`
`204`	`204`	`});`
`205`	`205`	`} else {`
`206`	`206`	`this.__selectedMap.forEach(idx => {`
`207`		- this.linkPaths(JSCompiler_renameProperty('selected', this), `${JSCompiler_renameProperty('items', this)}.` + idx);
`208`		- this.linkPaths(JSCompiler_renameProperty('selectedItem', this), `${JSCompiler_renameProperty('items', this)}.` + idx);
	`207`	+ this.linkPaths(JSCompiler_renameProperty('selected', this), `${JSCompiler_renameProperty('items', this)}.${idx}`);
	`208`	+ this.linkPaths(JSCompiler_renameProperty('selectedItem', this), `${JSCompiler_renameProperty('items', this)}.${idx}`);
`209`	`209`	`});`
`210`	`210`	`}`
`211`	`211`	`}`
`@@ -260,7 +260,7 @@`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`__selectedIndexForItemIndex(idx) {`
`263`		- let selected = this.__dataLinkedPaths[`${JSCompiler_renameProperty('items', this)}.` + idx];
	`263`	+ let selected = this.__dataLinkedPaths[`${JSCompiler_renameProperty('items', this)}.${idx}`];
`264`	`264`	`if (selected) {`
`265`	`265`	return parseInt(selected.slice(`${JSCompiler_renameProperty('selected', this)}.`.length), 10);
`266`	`266`	`}`