Skip to content

Commit c8715b5

Browse files
committed
Fix TypeScript breakages by specifying types for overridden setAttribute and getAttribute.
1 parent 282bd34 commit c8715b5

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

lib/legacy/legacy-element-mixin.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,11 @@ export const LegacyElementMixin = dedupingMixin((base) => {
143143
}
144144
}
145145

146-
/** @override */
146+
/**
147+
* @override
148+
* @param {string} name
149+
* @param {string} value
150+
*/
147151
setAttribute(name, value) {
148152
if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
149153
const oldValue = this.getAttribute(name);
@@ -155,7 +159,10 @@ export const LegacyElementMixin = dedupingMixin((base) => {
155159
}
156160
}
157161

158-
/** @override */
162+
/**
163+
* @override
164+
* @param {string} name
165+
*/
159166
removeAttribute(name) {
160167
if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
161168
const oldValue = this.getAttribute(name);

0 commit comments

Comments
 (0)