Skip to content

Automated build for PRs? #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brian-rose opened this issue Jan 7, 2021 · 3 comments
Closed

Automated build for PRs? #16

brian-rose opened this issue Jan 7, 2021 · 3 comments

Comments

@brian-rose
Copy link
Member

While #15 adds instructions for users to build the portal site locally, which is great for testing purposes, it would be even better to automate this.

Is there a github action or other mechanism we can use so that the rendered site is built automatically for every open pull request? E.g. anyone can download a zip file of the rendered site and view locally in a browser?
@andersy005 andersy005 mentioned this issue Jan 7, 2021
Merged
@andersy005
Copy link
Member

Now that #17 has been merged, any subsequent PR event will trigger a build on Readthedocs... Clicking on details takes the user to a preview link on Readthedocs:

Screen Shot 2021-01-07 at 6 16 54 PM

@brian-rose
Copy link
Member Author

@andersy005 this is great! I just test-drove this over at #15 and it works great. This should accelerate our work of building out the site.

@brian-rose
Copy link
Member Author

I'll close this, since we now have a great working solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brian-rose @andersy005