Skip to content

Enable team review requests for this repo #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brian-rose opened this issue Apr 28, 2021 · 2 comments · Fixed by #105
Closed

Enable team review requests for this repo #65

brian-rose opened this issue Apr 28, 2021 · 2 comments · Fixed by #105
Labels
infrastructure Infrastructure related issue

Comments

@brian-rose
Copy link
Member

Currently this repo has relatively rigid review requirements. Merging is blocked until 2 reviews are submitted by specific people listed as CODEOWNERS.

This is especially limiting for any changes in the top-most level of the repo, such as edits to the README file (e.g. #64), because the list of CODEOWNERS is small and somewhat arbitrary.

I suggest it would be better to adopt the GitHub Teams model that we are currently using for https://github.com/ProjectPythia/pythia-foundations

@brian-rose brian-rose added the infrastructure Infrastructure related issue label Apr 28, 2021
@kmpaul
Copy link
Collaborator

kmpaul commented May 20, 2021

@clyne
Copy link
Contributor

clyne commented Jun 3, 2021

We should revisit after we've had experience with "round robin" scheduler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants