Skip to content

possible test failure in upcoming Julia version 1.5 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rfourquet opened this issue May 3, 2020 · 1 comment · Fixed by #81
Closed

possible test failure in upcoming Julia version 1.5 #80

rfourquet opened this issue May 3, 2020 · 1 comment · Fixed by #81

Comments

@rfourquet
Copy link

A PkgEval run for a Julia pull request which changes the generated numbers for rand(a:b) indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master branch).

Also, you might be interested in using the new StableRNGs.jl registered package, which provides guaranteed stable streams of random numbers across Julia releases.

Apologies if this is a false positive. Cf. https://github.com/JuliaCI/NanosoldierReports/blob/ab6676206b210325500b4f4619fa711f2d7429d2/pkgeval/by_hash/52c2272_vs_47c55db/logs/ParallelKMeans/1.5.0-DEV-87d2a04de3.log
@Arkoniak
Copy link
Collaborator

Arkoniak commented May 3, 2020

Yes, I've read the corresponding discussion in the discourse, and I found it quite meaningful.
Thank you for bringing attention to this issue.

This was referenced May 3, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved support of MLJ Arkoniak/ParallelKMeans.jl
2 participants
@Arkoniak @rfourquet