Skip to content

Improve datamodel unitary tests for SWMM #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tproduit opened this issue Dec 15, 2022 · 1 comment
Open

Improve datamodel unitary tests for SWMM #785

tproduit opened this issue Dec 15, 2022 · 1 comment
Assignees
Labels

Comments

@tproduit
Copy link

tproduit commented Dec 15, 2022

In https://github.com/QGEP/datamodel/blob/master/test/test_swmm.py, the tests are based on the number of object expected in the views. Once that the SWMM export will be more mature, the tests should rely on the number of objects in the main tables.

Exemple:
If there are 5095 reaches in qgep_od.reach, there should be 5095 conduits in SWMM.

However, other relations might be less straightforward.

@cymed
Copy link

cymed commented Mar 14, 2023

In https://github.com/QGEP/datamodel/blob/master/test/test_swmm.py, the tests are based on the number of object expected in the views. Once that the SWMM export will be more mature, the tests should rely on the number of objects in the main tables.

Exemple: If there are 5095 reaches in qgep_od.reach, there should be 5095 conduits in SWMM.

However, other relations might be less straightforward.

Even with the reaches the number of objects should differ eventually, as we dont need abandonded reaches in the SWMM model.
In general, we should overthink the way we handle the statuses planned and current. Elements may be only current (statuses operational.tentative and operational.will_be_suspended), current and planned (operative), planned only (other.*) or none of the above (inoperative, abandoned.*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants