fix(message-parser): Fix payload generation for custom protocols (#799)

Author: ggazzo

packages/message-parser/src/utils.ts

@@ -67,14 +67,19 @@ export const plain = generate('PLAIN_TEXT');
 export const strike = generate('STRIKE');
 
 export const codeLine = generate('CODE_LINE');
+
+const isValidLink = (link: string) => {
+  try {
+    return Boolean(new URL(link));
+  } catch (error) {
+    return false;
+  }
+};
 export const link = (() => {
   const fn = generate('LINK');
 
   return (src: string, label?: Markup) => {
-    const href =
-      src !== '' && !src.startsWith('http') && !src.startsWith('//')
-        ? `//${src}`
-        : src;
+    const href = isValidLink(src) || src.startsWith('//') ? src : `//${src}`;
 
     return fn({ src: plain(href), label: label || plain(src) });
   };

packages/message-parser/tests/link.test.ts

@@ -235,6 +235,10 @@ test.each([
     'http:/ google.com',
     [paragraph([plain('http:/ '), link('//google.com', plain('google.com'))])],
   ],
+  [
+    '[custom](custom://google.com)',
+    [paragraph([link('custom://google.com', plain('custom'))])],
+  ],
 ])('parses %p', (input, output) => {
   expect(parser(input)).toMatchObject(output);
 });

packages/message-parser/tests/url.test.ts

@@ -58,6 +58,56 @@ test.each([
     [paragraph([link('ftp://user:pass@localhost:21/etc/hosts')])],
   ],
   ['ssh://test@test.test', [paragraph([link('ssh://test@test.test')])]],
+  ['custom://test@test.test', [paragraph([link('custom://test@test.test')])]],
+  ['ftp://test.com', [paragraph([link('ftp://test.com')])]],
 ])('parses %p', (input, output) => {
   expect(parser(input)).toMatchObject(output);
 });
+
+describe('link helper function', () => {
+  it('should preserve the original protocol if the protocol is http or https', () => {
+    expect(link('https://rocket.chat/test')).toMatchObject({
+      type: 'LINK',
+      value: {
+        src: plain('https://rocket.chat/test'),
+        label: plain('https://rocket.chat/test'),
+      },
+    });
+    expect(link('http://rocket.chat/test')).toMatchObject({
+      type: 'LINK',
+      value: {
+        src: plain('http://rocket.chat/test'),
+        label: plain('http://rocket.chat/test'),
+      },
+    });
+  });
+
+  it('should preserve the original protocol even if for custom protocols', () => {
+    expect(link('custom://rocket.chat/test')).toMatchObject({
+      type: 'LINK',
+      value: {
+        src: plain('custom://rocket.chat/test'),
+        label: plain('custom://rocket.chat/test'),
+      },
+    });
+  });
+
+  it('should return // as the protocol if // is the protocol specified', () => {
+    expect(link('//rocket.chat/test')).toMatchObject({
+      type: 'LINK',
+      value: {
+        src: plain('//rocket.chat/test'),
+        label: plain('//rocket.chat/test'),
+      },
+    });
+  });
+  it("should return an url concatenated '//' if the url has no protocol", () => {
+    expect(link('rocket.chat/test')).toMatchObject({
+      type: 'LINK',
+      value: {
+        src: plain('//rocket.chat/test'),
+        label: plain('rocket.chat/test'),
+      },
+    });
+  });
+});