feat(fuselage): Add message status indicator text component #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougfabris
changed the title
tassoevan
requested changes
Jul 11, 2022
There was a problem hiding this comment.
I suggest to drop the spreading of resting ...props because it feels like we're falling into two code smells, one being the classic Long Parameter List, and the other one is more related to TypeScript: as we are not restricting props shape on MessageStatusIndicatorTextProps, it can be anything, even properties not supported by the underlying <div /> element.
I know it's something we've done regularly in this codebase, but we're discouraging the practice now.
packages/fuselage/src/components/Message/MessageStatusIndicator/MessageStatusIndicatorText.tsx
Outdated
Show resolved
Hide resolved
packages/fuselage/src/components/Message/MessageStatusIndicator/MessageStatusIndicatorText.tsx
Outdated
Show resolved
Hide resolved
tassoevan
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Further comments
Add a component to show the text status in a message.
This component will be used to show the translation provider on rocketchat app