Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(message-parser): Enabling Emphasis elements (bold, strike and italic) inside link label #864

Merged
merged 8 commits into from
Oct 27, 2022
Merged

feat(message-parser): Enabling Emphasis elements (bold, strike and italic) inside link label #864

merged 8 commits into from
Oct 27, 2022

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Oct 10, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Currently, the message parser does not accept Emphasis elements mixed with plain text

[Normal Link - *Bold*, _Italic_ and ~strike~ Styles](https://rocket.chat/) return plain text → Should return a Link with bold/italic/strike

To fix this behavior it was necessary to edit the LinkSpan component in the gazzodown package (Pull Request here) and the grammar/utils files in this Pull Request

Send this markdown text:

[Test with *bold* element](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)
[Test with _italic_ element](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)
[Test with ~strike~ element](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)
[Test with *_~all emphasis~_* elements](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)

Current Behavior:

image

Expected Behavior

image

Issue(s)

Further comments

P.S: Do not merge this until @RocketChat/reactnative team merges this feature in the Mobile app

TC-91

@hugocostadev hugocostadev mentioned this pull request Oct 10, 2022
Merged
guijun13
guijun13 previously requested changes Oct 18, 2022
View reviewed changes
@reinaldonetof reinaldonetof mentioned this pull request Oct 20, 2022
Merged
10 tasks
@tassoevan tassoevan dismissed guijun13’s stale review October 27, 2022 12:25

Everything was fixed

@tassoevan tassoevan merged commit 7e521bb into develop Oct 27, 2022
@tassoevan tassoevan deleted the fix/emphasis-link branch October 27, 2022 19:18
tassoevan added a commit that referenced this pull request Oct 31, 2022
@tassoevan
Revert "feat(message-parser): Enabling Emphasis elements (bold, strik…
4dc07d7 
…e and italic) inside link label (#864)"

This reverts commit 7e521bb.
@tassoevan tassoevan restored the fix/emphasis-link branch October 31, 2022 17:16
@gabriellsh gabriellsh mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

@guijun13 guijun13 guijun13 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugocostadev @tassoevan @guijun13