Skip to content

Commit 5489b7a

Browse files
fix(fuselage): use label on Select (#1066)
1 parent c32bd73 commit 5489b7a

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

packages/fuselage/src/components/Option/Option.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ type OptionProps = {
3131
spacedColumn?: boolean;
3232
variant?: 'danger' | 'success' | 'warning' | 'primary';
3333
onClick?: (event: MouseEvent<HTMLElement>) => void;
34-
} & AllHTMLAttributes<HTMLElement>;
34+
} & Omit<AllHTMLAttributes<HTMLElement>, 'label'>;
3535

3636
const Option = memo(
3737
forwardRef(

packages/fuselage/src/components/Select/Listbox.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ function OptionAria({ item, state }: OptionProps) {
8484
selected={isSelected}
8585
focus={isFocused}
8686
key={item.key}
87+
label={item.rendered}
8788
{...optionProps}
8889
>
8990
{item.rendered}

packages/fuselage/src/components/Select/Select.styles.scss

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
@use '../../styles/lengths.scss';
12
@use '../../styles/typography.scss';
23

34
.rcx-select {
@@ -6,6 +7,8 @@
67

78
align-items: center;
89

10+
min-height: lengths.size(40);
11+
912
// TODO move to .rcx-input-box
1013
&__item {
1114
@include typography.use-text-ellipsis;

0 commit comments

Comments
 (0)