Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor static styles #201

Merged
merged 15 commits into from
Apr 20, 2020
Merged

feat: Refactor static styles #201

merged 15 commits into from
Apr 20, 2020

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Apr 19, 2020 •
edited
Loading

  • Remove unused CSS variables;
  • Prepare colors to dark mode;
  • Expand and update stylelint rules;
  • Push for more CSS logical properties;
  • Replace @import with @useof Sass modules.

As a side-effect, ~20kB where saved in the production bundle.

@tassoevan tassoevan force-pushed the improve/static-styles branch 2 times, most recently from ea480fd to 10e7de6 Compare April 20, 2020 03:49
@tassoevan tassoevan requested a review from a team April 20, 2020 04:46
@tassoevan tassoevan added ➕ Enhancement New feature or request 💅 Styles labels Apr 20, 2020
@tassoevan tassoevan changed the title improve/static-styles feat: Refactor static styles Apr 20, 2020
@tassoevan tassoevan marked this pull request as ready for review April 20, 2020 04:47
ggazzo
ggazzo previously approved these changes Apr 20, 2020
View reviewed changes
@tassoevan tassoevan force-pushed the improve/static-styles branch from fdac874 to 4d6200b Compare April 20, 2020 13:12
@tassoevan tassoevan merged commit e1bdc65 into develop Apr 20, 2020
@tassoevan tassoevan deleted the improve/static-styles branch April 20, 2020 14:04
ggazzo added a commit that referenced this pull request Apr 20, 2020
@ggazzo
Merge branch 'fiz/avatar' into table
04a2448 
* fiz/avatar:
  uodate
  fix avatar sizes
  fix: Update Callout to allow empty children (#200)
  feat: Refactor static styles (#201)
  Force default flex properties on Box styles (#197)
  Add more rich text block elements (#196)
  fix: Center Throbber circles (#198)
  chore: Fix Storybook test and build (#199)
  regression: Use NODE_ENV=loki in CircleCI
  chore: Only append jest-results.json in production builds of Storybook
  chore: Update Storybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo left review comments

Assignees
No one assigned
Labels
➕ Enhancement New feature or request 💅 Styles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo