-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New hooks for element size tracking #413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ggazzo Please review, sir. |
00a7874
to
a7f9c9a
Compare
234f0b2
to
6c9939f
Compare
…into feat/size-hooks
…into feat/size-hooks
…into feat/size-hooks
ggazzo
approved these changes
Nov 18, 2021
This was referenced May 18, 2023
This was referenced May 20, 2023
This was referenced Jun 13, 2023
This was referenced Sep 13, 2023
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The
useResizeObserver()
hook has a remarkable flaw when used as a replacement for container queries for styling: its initial state is asynchronously set. This pull request introduces two distinct hooks,useBorderBoxSize()
anduseContentBoxSize()
, which must be used instead to avoid flickering in components that need to know a element size to render valid JSX. E.g.: