Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Peggy loader options #459

Merged
merged 1 commit into from
May 21, 2021
Merged

fix: Peggy loader options #459

merged 1 commit into from
May 21, 2021

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented May 21, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

The option format: 'commonjs' must be default, otherwise Peggy.js will output an IIFE.

Issue(s)

Further comments

@tassoevan tassoevan requested a review from a team May 21, 2021 02:04
@ggazzo ggazzo merged commit fc91054 into develop May 21, 2021
@ggazzo ggazzo deleted the fix/peggy-loader-options branch May 21, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
📦 peggy-loader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo